Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEUS-1071: Distinguish AMP invoices #2014

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Mar 2, 2024

Description

Relates to issue: ZEUS-1071
Built on top of: #2013

This PR helps distinguish AMP invoices from standard invoices in the UI with the following changes:

  • Activity Filter: ability to filter by AMP invoices and Standard invoices
  • Activity: AMP invoices distinguished by Requested Payment (AMP) and You received (AMP)
  • Activity: settled AMP invoices use creation date and timestamp, instead of problematic settle date (which resolves to epoch)
  • Invoice: settled AMP invoices do not display problematic settle date (which resolves to epoch)
  • Invoice: Invoice amount displayed to distinguish from total received amount at top

Before and After screenshots:

Untitled1 Untitled2 Untitled3

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.8.2 milestone Mar 2, 2024
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 5bc0ce2 into ZeusLN:master Mar 4, 2024
3 checks passed
@kaloudis kaloudis deleted the zeus-1071 branch March 4, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants