Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taproot: send and receive #980

Merged
merged 3 commits into from May 20, 2022
Merged

Taproot: send and receive #980

merged 3 commits into from May 20, 2022

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented May 17, 2022

Adds the ability for LND v0.15+ users to send and receive to Taproot addresses.

P2TR address validation has been added here: #614

Screenshot_1652837524

@kaloudis
Copy link
Contributor Author

Awaiting UI design from @Bosch-0

@Bosch-0
Copy link
Collaborator

Bosch-0 commented May 17, 2022

We could make a new component called BottomModalMenu see below. Isolated component on the left, component shown in context on the right:

image

The one with the yellow border is the currently selected item. Tapping the darker outside area or sliding the modal downwards collapses it.

This could be re-used in other areas of Zeus, not just for address stuff.

We can polish the request screen when we get to #946

Figma source file

@kaloudis kaloudis force-pushed the taproot branch 4 times, most recently from e0fc0f4 to 2b97aea Compare May 18, 2022 00:29
@kaloudis kaloudis marked this pull request as ready for review May 18, 2022 00:30
@kaloudis kaloudis force-pushed the taproot branch 3 times, most recently from e2653fb to 973ce69 Compare May 18, 2022 01:15
@kaloudis kaloudis merged commit 8acf4b2 into ZeusLN:master May 20, 2022
@kaloudis kaloudis deleted the taproot branch May 20, 2022 13:23
@Bosch-0 Bosch-0 mentioned this pull request May 23, 2022
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants