Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking fixes #983

Merged
merged 1 commit into from May 20, 2022
Merged

Linking fixes #983

merged 1 commit into from May 20, 2022

Conversation

kaloudis
Copy link
Contributor

Description

Linking was only working when the app was closed. Users would lose the eventListener for linking events once they navigated away from the Home view.

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Other

Checklist

  • I’ve run npm run tsc and made sure my code compiles correctly
  • I’ve run npm run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run npm run prettier and made sure my code is formatted correctly
  • I’ve run npm run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND
  • c-lightning-REST
  • spark
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run npm install after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and package-lock.json have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis merged commit 9ab640e into ZeusLN:master May 20, 2022
@kaloudis kaloudis deleted the linking-fixes branch May 20, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant