Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to new FK api #557

Merged
merged 9 commits into from Aug 3, 2017
Merged

Adapt to new FK api #557

merged 9 commits into from Aug 3, 2017

Conversation

VandorpeDavid
Copy link
Contributor

No description provided.

@VandorpeDavid
Copy link
Contributor Author

User.fetch_club is only called on creation afaik. Does this mean the clubs of a user can't change afterwards?

@VandorpeDavid
Copy link
Contributor Author

Tests fail due to 404 (likely at https://github.com/ZeusWPI/Gandalf/blob/master/db/seeds.rb#L11)

@TomNaessens TomNaessens self-requested a review August 1, 2017 11:27
TomNaessens
TomNaessens approved these changes Aug 1, 2017
View reviewed changes
Copy link
Member

@TomNaessens TomNaessens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok if the test succeed

@VandorpeDavid
Copy link
Contributor Author

Tests fail due to an issue with ghostscript on Travis, they do succeed locally.

@VandorpeDavid VandorpeDavid reopened this Aug 3, 2017
@VandorpeDavid VandorpeDavid merged commit 6543c25 into master Aug 3, 2017
@TomNaessens TomNaessens deleted the new_fk_api branch October 2, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomNaessens TomNaessens TomNaessens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VandorpeDavid @TomNaessens