Fix tests in CI #241
Merged
Fix tests in CI #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chvp
force-pushed
the
fix/ci-tests
branch
9 times, most recently
from
8b16bc2
to
d1b95c9
Compare
|
I understand the actual problem. The mails are delivered "too late". Adding a sleep fixes it, because that allows the future that "delivers" the mail to finish. |
chvp
force-pushed
the
fix/ci-tests
branch
7 times, most recently
from
1e36e64
to
2ba2084
Compare
|
Changed the fix to assert delivery of the mails that were delivered late. This still sleeps under the hood but makes more semantic sense and should result in clearer errors should the sleep turn out to be insufficient. |
redfast00
approved these changes
Mar 1, 2023
rien
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.