Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cash (btc) is always zero #17

Closed
ziofil opened this issue Dec 12, 2017 · 5 comments
Closed

cash (btc) is always zero #17

ziofil opened this issue Dec 12, 2017 · 5 comments

Comments

@ziofil
Copy link

ziofil commented Dec 12, 2017

In the new portfolio vector (raw omega) the cash (btc) is always zero. But this cannot be always the best choice: what if all the other currencies are losing value in a period? surely in this case the best choice is to move all the assets back to cash.

In the code, the cash bias is initialized to zero just before the final softmax, so it cannot be anything else than zero. Was this intended?

@AhmMontasser
Copy link

among the possible coin choices there is a reversed_USDT coin mapping to BTC_USDT pair, which i believe is exactly what you say.

@dexhunter
Copy link
Collaborator

In the new portfolio vector (raw omega) the cash (btc) is always zero.

@ziofil Hi! Since the last activation is softmax, the voting will be adjusted according to the network. It all depends on the network. If the network thinks BTC is valuable it will just lower other assets' voting.

@dexhunter
Copy link
Collaborator

An example looks like this:

a = [0,1,2]
softmax(a) -> array([ 0.09003057, 0.24472847, 0.66524096])

b = [0,0.1,0.2]
softmax(b) -> array([ 0.30060961, 0.33222499, 0.3671654 ])

screenshot_2017-12-13_15-35-41

@ziofil
Copy link
Author

ziofil commented Dec 13, 2017

@dexhunter Oohhh.. I had missed that 😅
Thank you.

@dexhunter
Copy link
Collaborator

@ziofil No problem, I met this problem before. I think we will update the code using Variable later since I found using Variable seems to give better result. But will check with @ZhengyaoJiang first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants