fix: coollapse font-size #1078
fix: coollapse font-size #1078
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| - 解决 renderImperative React 18 异步渲染问题 [#1076](https://github.com/ZhongAnTech/zarm/pull/1076) | |||
| - [List.Item] 修复单独引用样式丢失 [#1075](https://github.com/ZhongAnTech/zarm/pull/1075) | |||
| - [Collapse] 修复标题默认字体 [#1077](https://github.com/ZhongAnTech/zarm/pull/1077) | |||
|
|
|||
| ## v3.0.8 | |||
|
|
|||
There was a problem hiding this comment.
the code review
Firstly, it's good to see that the code patch is well documented, with references to the corresponding Github issues. This makes it easier to understand the purpose of the patch.
From a code review perspective, we need to look at the actual code changes and make sure that it does what it's supposed to do and does not introduce any bugs. We need to look for any potential risks, such as typos and incorrect logic, and suggest any improvements if necessary.
For this particular patch, it seems to be adding a fix for the default font in the Collapse component. We need to make sure that the logic is correct and that the font has been successfully reloaded with the correct settings. We should also check the code to make sure that there are no typos or any other errors that could lead to unexpected results.
Finally, if there are any suggestions on how to improve the code, this could be discussed and implemented if appropriate.
|
🎊 PR Preview has been successfully built and deployed to https://zarm-preview-pr-1078.surge.sh
|
| @@ -51,6 +51,7 @@ | |||
|
|
|||
| @include e(title) { | |||
| flex: 1; | |||
| font-size: 17px; | |||
| } | |||
|
|
|||
| @include e(content) { | |||
There was a problem hiding this comment.
with a brief overview of the code patch above. The code adds a font-size styling to the e(title) class. This style addition is necessary to ensure that the title text is displayed correctly in the UI. It is also important to make sure that the font size is compatible with other elements on the page, so it is important to check if the font size fits with the rest of the page and if any additional styling needs to be done. Additionally, it would be worth checking if this font size is appropriate for all screen sizes and devices.
|
|
||
| - Bug Fix | ||
|
|
||
| - [ImagePreview] 修复点击图片穿透问题 [#1073](https://github.com/ZhongAnTech/zarm/pull/1073) | ||
|
|
||
| ## v3.0.8 | ||
|
|
There was a problem hiding this comment.
with a brief overview of the code:
This patch is for version 3.0.10 of the ZhongAnTech/zarm repository, and contains several bug fixes. The first fix resolves the renderImperative React 18 asynchronous rendering issue (#1076). The second fix corrects the missing styles when List.Item is used alone (#1075). The third fix updates the default font for the Collapse title (#1077). The fourth fix resolves the ImagePreview click through issue (#1073).
Codecov Report
@@ Coverage Diff @@
## master #1078 +/- ##
==========================================
- Coverage 90.64% 83.59% -7.06%
==========================================
Files 239 17 -222
Lines 5346 128 -5218
Branches 1227 18 -1209
==========================================
- Hits 4846 107 -4739
+ Misses 490 21 -469
+ Partials 10 0 -10 see 222 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
No description provided.