Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zarm/panel): Improved panel component #1085

Merged
merged 7 commits into from Apr 11, 2023
Merged

feat(zarm/panel): Improved panel component #1085

merged 7 commits into from Apr 11, 2023

Conversation

mrdulin
Copy link
Contributor

@mrdulin mrdulin commented Apr 3, 2023

  1. 没有titlemore props时,不渲染header节点
  2. 添加更多测试
  3. 使用useImperativeHandle(ref, createHandle, dependencies?)将ref暴露给父组件
  4. 调整TS类型,导出type Ref = HTMLDivElement类型,

ref在组件内被传递给哪个组件或者HTML element,客户端如果不看代码或者TS类型报错之前,是不知道的,导出Ref类型

@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zarm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2023 3:11am

@cr-gpt
Copy link

cr-gpt bot commented Apr 3, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables for this repo. you could follow readme for more information

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

🎊 PR Preview has been successfully built and deployed to https://zarm-preview-pr-1085.surge.sh

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1085 (2818bcf) into master (441a6fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1085   +/-   ##
=======================================
  Coverage   90.64%   90.64%           
=======================================
  Files         239      239           
  Lines        5346     5347    +1     
  Branches     1227     1270   +43     
=======================================
+ Hits         4846     4847    +1     
  Misses        490      490           
  Partials       10       10           
Impacted Files Coverage Δ
packages/zarm/src/panel/index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cr-gpt
Copy link

cr-gpt bot commented Apr 4, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables for this repo. you could follow readme for more information

@vercel vercel bot temporarily deployed to Preview – zarm April 4, 2023 02:46 Inactive
@mrdulin mrdulin changed the title feat(zarm/panel): do not render header if there are no title and more… feat(zarm/panel): Improved panel component Apr 4, 2023
@cr-gpt
Copy link

cr-gpt bot commented Apr 4, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables for this repo. you could follow readme for more information

@vercel vercel bot temporarily deployed to Preview – zarm April 4, 2023 02:54 Inactive
packages/zarm/src/panel/interface.ts Outdated Show resolved Hide resolved
packages/zarm/src/panel/index.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – zarm April 4, 2023 07:05 Inactive
@vercel vercel bot temporarily deployed to Preview – zarm April 4, 2023 07:30 Inactive
@vercel vercel bot temporarily deployed to Preview – zarm April 4, 2023 08:10 Inactive
@vercel vercel bot temporarily deployed to Preview – zarm April 10, 2023 03:11 Inactive
@dominicleo dominicleo merged commit bfe51a0 into ZhongAnTech:master Apr 11, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants