Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: carousel #1098

Merged
merged 3 commits into from May 15, 2023
Merged

perf: carousel #1098

merged 3 commits into from May 15, 2023

Conversation

Yang03
Copy link
Contributor

@Yang03 Yang03 commented Apr 27, 2023

No description provided.

@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zarm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 10:07am

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

🎊 PR Preview has been successfully built and deployed to https://zarm-preview-pr-1098.surge.sh

@vercel vercel bot temporarily deployed to Preview – zarm April 27, 2023 06:10 Inactive
@JeromeLin JeromeLin added the gpt review code review label Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #1098 (2ec2ec3) into master (de00ef8) will decrease coverage by 88.64%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #1098       +/-   ##
==========================================
- Coverage   90.64%   2.00%   -88.64%     
==========================================
  Files         239     238        -1     
  Lines        5346    5327       -19     
  Branches     1227    1215       -12     
==========================================
- Hits         4846     107     -4739     
- Misses        490    5219     +4729     
+ Partials       10       1        -9     
Impacted Files Coverage Δ
packages/zarm/src/carousel/index.tsx 0.00% <0.00%> (-93.71%) ⬇️

... and 222 files with indirect coverage changes

@JeromeLin JeromeLin added gpt review code review and removed gpt review code review labels Apr 27, 2023
@JeromeLin
Copy link
Collaborator

手动移动的过程中,需要把自动轮播定时器暂停,并重置时间。

@vercel vercel bot temporarily deployed to Preview – zarm April 28, 2023 02:29 Inactive
@JeromeLin
Copy link
Collaborator

手动一直向左轮播,会有一定几率触发反方向的自动滑动

@vercel vercel bot temporarily deployed to Preview – zarm May 8, 2023 01:56 Inactive
@JeromeLin
Copy link
Collaborator

滑动一段距离松开,最后面2个例子中有时候会没有回弹动画。

@vercel vercel bot temporarily deployed to Preview – zarm May 9, 2023 13:15 Inactive
@vercel vercel bot temporarily deployed to Preview – zarm May 11, 2023 10:07 Inactive
@JeromeLin JeromeLin merged commit 159fca0 into ZhongAnTech:master May 15, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants