Updated code to regz rewrite and added fix for i2c on ATmega328P #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marnix
added a commit
to marnix/microzig
that referenced
this pull request
Oct 28, 2023
This slightly generalizes the earlier commit 2852e56 from ZigEmbeddedGroup#125.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly changes to imports/variables that changed.
The i2c fix prevents the controller form hanging/crash when running this line
const i2c = try interfaces.i2c.I2CController(0, .{}).init(.{ .target_speed = 400_000 });.I think this is caused because the struct that is returned contains just functions so it has size 0 and clangs avr code gen cant handle that properly.