Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature import/export with dot files #287

Merged
merged 8 commits into from
May 11, 2023
Merged

Feature import/export with dot files #287

merged 8 commits into from
May 11, 2023

Conversation

sbaldu
Copy link
Collaborator

@sbaldu sbaldu commented May 10, 2023

Implementation of methods for the Graph class which allow to construct a graph by importing it from a DOT file or to export it to a DOT file (#244).

@github-actions github-actions bot added core something about core test Something about test labels May 10, 2023
@ghost
Copy link

ghost commented May 10, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@ZigRazor ZigRazor self-requested a review May 10, 2023 13:14
@ZigRazor
Copy link
Owner

please resolve conflict, or we can't continue.
Thank you!

nrkramer
nrkramer approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@nrkramer nrkramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sbaldu, thanks for opening this PR! So far the changes look fantastic.

The conflict is because I recently changed the root-level namespace to title-case.

@sbaldu
Copy link
Collaborator Author

sbaldu commented May 10, 2023 •
edited

@nrkramer Hi, I'm glad you like the changes.
I've merged your changes in my branch so now the conflict should be fixed.

@nrkramer
Copy link
Collaborator

Merge LGTM

@ZigRazor ZigRazor linked an issue May 11, 2023 that may be closed by this pull request
Import/Export from/to DOT file #244
Closed
@ZigRazor ZigRazor self-assigned this May 11, 2023
@ZigRazor ZigRazor merged commit daf32ed into ZigRazor:master May 11, 2023
5 of 9 checks passed
@sbaldu sbaldu deleted the feature_DOT_Files branch May 22, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrkramer nrkramer nrkramer approved these changes

@ZigRazor ZigRazor ZigRazor approved these changes

Assignees

@ZigRazor ZigRazor

Labels
core something about core test Something about test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import/Export from/to DOT file
3 participants
@sbaldu @ZigRazor @nrkramer