Add tests for different node data types and methods for setting node data #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrkramer
reviewed
May 15, 2023
sbaldu
force-pushed
the
fix_template_type_support
branch
from
a32d3e0
to
f8ceb79
Compare
nrkramer
approved these changes
May 16, 2023
ZigRazor
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #288 an error has been fixed which prevented users from using non-numeric template type parameters.
Here I've added some tests in the *EdgeTest.cpp files, to check that everything works for all types. The only requirement is that the type parameters provides overloads of equality and iostream operators ( all this was discussed in issue #284 ).
In addition to this, I've added methods in Node and Graph classes which allow to set the data of the nodes after their constructions.
I think that this would be useful in some applications and is definitely needed when reading graphs from DOT files, because they don't allow to specify the data contained in the nodes.