Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature matrix market format #299

Merged
merged 12 commits into from
May 22, 2023
Merged

Conversation

sbaldu
Copy link
Collaborator

@sbaldu sbaldu commented May 21, 2023

Implementation of methods for import/export of graphs in Matrix Market (.mtx) format, issue #187 .

@github-actions github-actions bot added core something about core test Something about test labels May 21, 2023
@ghost
Copy link

ghost commented May 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

include/Graph/Graph.hpp Outdated Show resolved Hide resolved
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@ZigRazor
Copy link
Owner

Ok, before the approvation, can you reduce the violations reported by codacy with tool CPPCheck?

@sbaldu
Copy link
Collaborator Author

sbaldu commented May 22, 2023

Ok, before the approvation, can you reduce the violations reported by codacy with tool CPPCheck?

Hi. The violations by codacy are fixed, and so are most of those from CPPCheck.

@ZigRazor
Copy link
Owner

Good Job @sbaldu, do you want to become Collaborator for this project?

@ZigRazor ZigRazor merged commit 76a08d4 into ZigRazor:master May 22, 2023
20 of 21 checks passed
@ZigRazor ZigRazor linked an issue May 22, 2023 that may be closed by this pull request
@sbaldu
Copy link
Collaborator Author

sbaldu commented May 22, 2023

Good Job @sbaldu, do you want to become Collaborator for this project?

I would love to. Thank you so much!

@sbaldu sbaldu deleted the feature_matrix_market branch May 22, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core test Something about test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matrix Market Format for Input/Output
2 participants