-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create windows-cmake.yml #327
Conversation
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=======================================
Coverage 97.24% 97.24%
=======================================
Files 54 54
Lines 7907 7907
=======================================
Hits 7689 7689
Misses 218 218
Flags with carried forward coverage won't be shown. Click here to find out more. |
@nrkramer can you correct the cmake to let the MSVC compile? The problem seems to be the linking of pthread library, that obviously is not present in windows |
for compiling on windows
if(NOT gtest_disable_pthreads) | ||
target_link_libraries(test_exe PUBLIC pthread) | ||
endif(NOT gtest_disable_pthreads) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
These two tests rely on I think I'll need to experiment a bit when I have the time to hone in on where the problem lies. For example, creating a Otherwise, if anyone has any other ideas, they can push commits to this PR to see if the tests begin passing. |
yes, I think there is a bug in the STL, or in any case, we are in case that is not covered by the Microsoft STL. |
I merge this PR, in this way we can check in the future the problem, in any case for the moment the "Build and Tests" in windows CI/CD will fail. |
Added Windows CMake CI/CD