Update README.md #329
Merged
Update README.md #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates to intro, installation, packaging, and contributing sections
nrkramer
reviewed
Jul 13, 2023
| - A GCC compiler version greater than 7.3.0 *OR* | ||
| - A MSVC compiler that supports C++17 | ||
| - The minimum C++ standard required is **C++17** | ||
| - A GCC compiler version 7.3.0 and later *OR* a MSVC compiler that supports C++17 |
Comment on lines
-205
to
+202
| The use of the library is very simple, **just put the header file where you need!** | ||
| To use the library **simply put the header file where you need it.** It's that easy! |
There was a problem hiding this comment.
I don't think this is strictly true yet. I think there were plans to add a script to merge all the code into a single header. Do we have an issue to track this @ZigRazor ?
nrkramer
approved these changes
Jul 28, 2023
|
@ZigRazor This looks largely complete. Maybe we should just merge it as there's been no progress for awhile |
|
Hi there, I noticed that when I was working on #298 and noticed that for testing, I need to run mkdir -p build # Create a directory to hold the build output
cd build # Enter the build folder
cmake -DTEST=ON .. # Generate native build scripts for GoogleTest
make # Compileinstead of mkdir -p build # Create a directory to hold the build output
cd build # Enter the build folder
cmake .. # Generate native build scripts for GoogleTest
make # CompileIs my workflow wrong or is the doc needs updating |
|
The doc needs updating. Your workflow is correct. |
Should I create a branch and do a pull request? |
|
Please do! Thank you! 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some proposed updates to the following sections: