Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from CMake FetchContent to CMake Package Manager (CPM) #332

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

perhapsmaple
Copy link
Contributor

This pull request migrates the project from using CMake FetchContent to CMake Package Manager (CPM).
Related Issue: Closes #286

Changes Made:

  • Updated main CMakeLists.txt to fetch latest CPM.cmake script on execution
  • Removed FetchContent-related commands from benchmark/CMakeLists.txt and test/CMakeLists.txt

Testing:

  • I have tested the changes locally and ensured that the project builds successfully using CMake 3.24 on Ubuntu 22.04.
  • I have verified that the correct versions of the packages are being fetched by CPM.

@github-actions github-actions bot added test Something about test repo something about repo labels Jul 22, 2023
@ghost
Copy link

ghost commented Jul 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #332 (583c09f) into master (0ae7045) will not change coverage.
The diff coverage is n/a.

❗ Current head 583c09f differs from pull request most recent head a43337e. Consider uploading reports for the commit a43337e to get more accurate results

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files          54       54           
  Lines        7934     7934           
=======================================
  Hits         7716     7716           
  Misses        218      218           
Flag Coverage Δ
unittests 97.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ZigRazor ZigRazor self-requested a review July 24, 2023 06:02
@ZigRazor ZigRazor self-assigned this Jul 24, 2023
@ZigRazor ZigRazor merged commit 7afc54e into ZigRazor:master Jul 24, 2023
22 of 23 checks passed
@perhapsmaple perhapsmaple deleted the cpm-cmake branch August 12, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo something about repo test Something about test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from FetchContent to CPM in all CMakeLists.txt
2 participants