Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #345 fixed Node<T> move constructor #346

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

AryanGitHub
Copy link
Contributor

used std::move() in Node move constructor

A good pull request has the following information:

[----------] Global test environment tear-down
[==========] 246 tests from 33 test suites ran. (357 ms total)
[  PASSED  ] 246 tests.

@ZigRazor

 used std::move() in Node<T> move constructor
@github-actions github-actions bot added the core something about core label Sep 19, 2023
@ghost
Copy link

ghost commented Sep 19, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #346 (b2e99a0) into master (7c03e1a) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files          55       55           
  Lines        8455     8455           
=======================================
  Hits         8228     8228           
  Misses        227      227           
Flag Coverage Δ
unittests 97.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
include/Node/Node.hpp 100.00% <100.00%> (ø)

@ZigRazor ZigRazor merged commit 43e3830 into ZigRazor:master Sep 20, 2023
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core
Projects
None yet
2 participants