Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cached adjacency matrix in all Graph algorithms #358

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

sbaldu
Copy link
Collaborator

@sbaldu sbaldu commented Sep 28, 2023

Use the cached Adjacency matrix member of the Graph class in all the algorithms, instead of calling the getAdjMatrix method (issue #356)

@github-actions github-actions bot added the core something about core label Sep 28, 2023
@sbaldu sbaldu linked an issue Sep 28, 2023 that may be closed by this pull request
@ghost
Copy link

ghost commented Sep 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #358 (ae1e209) into master (4a74dcc) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
- Coverage   97.45%   97.44%   -0.02%     
==========================================
  Files          55       55              
  Lines        8961     8948      -13     
==========================================
- Hits         8733     8719      -14     
- Misses        228      229       +1     
Flag Coverage Δ
unittests 97.44% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/CXXGraph/Graph/Graph.hpp 95.54% <100.00%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

@ZigRazor ZigRazor merged commit b30e7b5 into ZigRazor:master Sep 29, 2023
11 of 14 checks passed
@sbaldu sbaldu deleted the feature_use_cachedAdjMatrix branch October 9, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of cached adjacency matrix in all algorithms
3 participants