Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement matrices used in network dynamics #366

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

carlosfrodrigues
Copy link
Contributor

Related to the issue #359.
Created the methods getDegreeMatrix, getLaplacianMatrix and getTransitionMatrix. I also added the caching mechanisms for the above matrices.

@github-actions github-actions bot added the core something about core label Oct 22, 2023
@ghost
Copy link

ghost commented Oct 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@ZigRazor ZigRazor self-requested a review October 23, 2023 07:23
Copy link
Owner

@ZigRazor ZigRazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are good, please add some documentation in the read, and if is possible some examples of use under the examples section

@ZigRazor ZigRazor self-assigned this Oct 23, 2023
@ZigRazor ZigRazor linked an issue Oct 23, 2023 that may be closed by this pull request
@github-actions github-actions bot added the repo something about repo label Oct 23, 2023
@carlosfrodrigues
Copy link
Contributor Author

The changes are good, please add some documentation in the read, and if is possible some examples of use under the examples section

Done, let me know if everything is ok!

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #366 (43151db) into master (a19c100) will increase coverage by 0.00%.
The diff coverage is 98.38%.

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   97.51%   97.52%           
=======================================
  Files          55       55           
  Lines        9174     9236   +62     
=======================================
+ Hits         8946     9007   +61     
- Misses        228      229    +1     
Flag Coverage Δ
unittests 97.52% <98.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/CXXGraph/Utility/Typedef.hpp 100.00% <ø> (ø)
include/CXXGraph/Graph/Graph.hpp 95.67% <98.38%> (+0.09%) ⬆️

@ZigRazor ZigRazor merged commit 7cd6b0c into ZigRazor:master Oct 24, 2023
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core repo something about repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement matrices used in network dynamics
2 participants