Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows builds are broken due to MSVC fold expression bug #416

Merged
merged 3 commits into from Apr 22, 2024
Merged

Windows builds are broken due to MSVC fold expression bug #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e00cbbd
Fix Windows builds
nolankramer Apr 22, 2024
17b9660
Run clang-format
nolankramer Apr 22, 2024
717f833
Run clang-format-16
nolankramer Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions include/CXXGraph/Graph/Algorithm/Boruvka_impl.hpp
View file
Open in desktop
Expand Up @@ -187,16 +187,16 @@
// Else check if current edge is closer to previous
// cheapest edges of set1 and set2
if (cheapest[set1] == INT_MAX ||
(edgeWeight[cheapest[set1]] > edgeWeight[edgeId]) ||
(edgeWeight[cheapest[set1]] == edgeWeight[edgeId] && cheapest[set1] > edgeId)
)
cheapest[set1] = edgeId;
(edgeWeight[cheapest[set1]] > edgeWeight[edgeId]) ||
(edgeWeight[cheapest[set1]] == edgeWeight[edgeId] &&
cheapest[set1] > edgeId))
cheapest[set1] = edgeId;

if (cheapest[set2] == INT_MAX ||
(edgeWeight[cheapest[set2]] > edgeWeight[edgeId]) ||
(edgeWeight[cheapest[set2]] == edgeWeight[edgeId] && cheapest[set2] > edgeId)
)
cheapest[set2] = edgeId;
(edgeWeight[cheapest[set2]] > edgeWeight[edgeId]) ||
(edgeWeight[cheapest[set2]] == edgeWeight[edgeId] &&
cheapest[set2] > edgeId))

Check warning on line 198 in include/CXXGraph/Graph/Algorithm/Boruvka_impl.hpp

View check run for this annotation

Codecov / codecov/patch

include/CXXGraph/Graph/Algorithm/Boruvka_impl.hpp#L198 

Added line #L198 was not covered by tests
cheapest[set2] = edgeId;
}

// iterate over all the vertices and add picked
Expand Down