-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nullptr guard-check in comparision of shared ptr node and edge #436
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
==========================================
+ Coverage 97.58% 97.87% +0.28%
==========================================
Files 87 87
Lines 9492 10063 +571
Branches 0 670 +670
==========================================
+ Hits 9263 9849 +586
+ Misses 229 214 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one! Thank you so much!
We are waiting the re-liensing #427, after that we can merge it! |
how should i pass the rest of the tests on ci/cd ? @ZigRazor |
The only one you can pass is the clang format, just formatting with clang. @badumbatish |
Fixes Clang's critical bug on the library where we're doing custom shared_ptr comparison with potentially null ptrs.
This will fix #433 but i think what we should also be doing is enforce nullptr safety on these custom operators on shared ptrs
This allows Clang on MacOS to pass all tests.
I added
to == operator in PointerHash()
@ZigRazor would love a review