Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macos ci/cd on cmake, benchmark and benchmark_pr #437

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

badumbatish
Copy link
Contributor

Recommend by Zig in #433

Would love a review as well @ZigRazor

@ZigRazor
Copy link
Owner

Maybe we can add also windows in the matrix, and remove the Windows Cmake file for CI/CD

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.88%. Comparing base (1b31e63) to head (7af9f44).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   97.58%   97.88%   +0.29%     
==========================================
  Files          87       87              
  Lines        9492    10057     +565     
  Branches        0      666     +666     
==========================================
+ Hits         9263     9844     +581     
+ Misses        229      213      -16     
Flag Coverage Δ
unittests 97.88% <ø> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badumbatish
Copy link
Contributor Author

Maybe we can add also windows in the matrix, and remove the Windows Cmake file for CI/CD

idk how the -Dgtest_disable_pthreads=ON option in windows_cmake will affect things when going on mac and ubuntu but i can push the changes if you want

@ZigRazor
Copy link
Owner

we can try, then if don't work, we can review it

@badumbatish
Copy link
Contributor Author

ok should be fixed now

@ZigRazor ZigRazor self-requested a review May 13, 2024 13:39
Copy link
Owner

@ZigRazor ZigRazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@ZigRazor
Copy link
Owner

We are waiting #427 to merge the PR

@badumbatish
Copy link
Contributor Author

Sounds good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants