Use longest match for ctx._matchedRoute, fixes #478 #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use most recently added layer as a tiebreaker
jcao219
force-pushed
the
fix-issue-478
branch
from
1ad877d
to
7eee811
Compare
|
Was running into this issue in needing to access the proper path pattern for the current route handler. Silly (useless) that it uses the first "parent" route path rather the more specific route handler. |
zacanger
added a commit
to zacanger/koa-modern-router
that referenced
this pull request
Feb 16, 2019
Apply changes from ZijianHe/koa-router#492 One test failing, will address after
|
@jaco219 this repo is abandoned. Maybe you'd be interested to contribute to the active repo instead: koajs/router#34 (comment) |
|
Let's close the issue. Feel free to merge my code into any forked repo if you feel like it. From the time I made this PR up until now, I've moved across continents twice. I also use fastify now (as my framework of choice). I haven't thought about Koa router in 12 whole months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #478 by using the longest path, or the length of path string as a tiebreaker to determine "most specific layer"
I tried to implement it without replacing RegExp.prototype.test with something that like RegExp.prototype.exec which returns more match information, as that would decrease routing performance.
This does subtly change the behavior of koa-router, though. Is 5.x release planned soon, and will it fix #478 ?