[ZIP-17] Provider API #50
Conversation
snowsledge
requested review from
snowsledge,
AmritKumar,
ansnunez,
arnavvohra,
bb111189,
hicaru,
renlulu and
micovi
|
Hi @krisboit I am assigning ZIP-17 to this ZIP |
| @@ -0,0 +1,97 @@ | |||
| | ZIP | Title | Status | Type | Author | Discussions-to | Created (yyyy-mm-dd) | Updated (yyyy-mm-dd) | | |||
| | :-: | ------------------------------------------ | :----: | --------------- | ------------------------------ | -------------- | -------------------- | -------------------- | | |||
| | X | URL Scheme Format for Transaction Requests | Draft | Standards Track | Tibi Krisboi <tibi@moonlet.io> | - | 2020-12-11 | 2020-12-11 | | |||
There was a problem hiding this comment.
| | X | URL Scheme Format for Transaction Requests | Draft | Standards Track | Tibi Krisboi <tibi@moonlet.io> | - | 2020-12-11 | 2020-12-11 | | |
| | 17 | URL Scheme Format for Transaction Requests | Draft | Standards Track | Tibi Krisboi <tibi@moonlet.io> | - | 2020-12-11 | 2021-01-15 | |
|
|
||
| ## Connectivity | ||
|
|
||
| The Provider is said to be **connected** when it can service RPC requests to ar least one network. |
There was a problem hiding this comment.
| The Provider is said to be **connected** when it can service RPC requests to ar least one network. | |
| The Provider is said to be **connected** when it can service RPC requests to at least one network. |
|
|
||
| ### Errors | ||
|
|
||
| Error responses **must** be in this format: {error: {code: number, message: string}}, where _code_ is the code of the error and _message_ a human readable error message. |
There was a problem hiding this comment.
| Error responses **must** be in this format: {error: {code: number, message: string}}, where _code_ is the code of the error and _message_ a human readable error message. | |
| Error responses **must** be in this format: {error: {code: number, message: string}}, where _code_ is the code of the error and _message_ a human-readable concise error message. |
|
Should this ZIP define a list of standard errors in a table format? The following example seems to be sharing the same error code Example:
|
|
Also rename the file to zip-17.md |
| - code: -1 message: CANCELED_BY_USER: Operation cancelled by user | ||
| - **SignMessage** | ||
| - Params: [message: string] | ||
| - message: string (required) - this method will be executed on wallet side, it will just singn the message and return an object of this form {signature: string, publicKey: string, message: string} |
There was a problem hiding this comment.
| - message: string (required) - this method will be executed on wallet side, it will just singn the message and return an object of this form {signature: string, publicKey: string, message: string} | |
| - message: string (required) - this method will be executed on wallet side, it will just sign the message and return an object of this form {signature: string, publicKey: string, message: string} |
Yeah, it should be a table. I drafted this as quick as I could just to get your opinion on it. Regarding the error codes, I was hoping you would help me define them to be on the same pattern as the errors returned by the RPC. I think it's crucial to assign the code so they don't already exist in RPC API and will not be used in future for other kind of errors. So @bb111189 I need your help on this :) |
hey. I can take a stab at it. Can you also give me write access to your branch so that it is easier from my end. |
Sure! I've sent you an invite. |
Hey,
This is just a first draft of the ZIP, I just put my ideas in words :) still a lot of changes needed.
Let's discuss about this PR in this issue: #51