Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating specs for JSONRPC #1054

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Updating specs for JSONRPC #1054

merged 2 commits into from
Dec 17, 2018

Conversation

KaustubhShamshery
Copy link
Contributor

@KaustubhShamshery KaustubhShamshery commented Dec 14, 2018

Description

Review Suggestion

Status

Implementation

  • ready for review

Reference issue:
https://github.com/Zilliqa/Issues/issues/222

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #1054 into master will decrease coverage by 1.67%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
- Coverage   30.13%   28.46%   -1.68%     
==========================================
  Files         245      245              
  Lines       25436    27127    +1691     
==========================================
+ Hits         7666     7721      +55     
- Misses      17770    19406    +1636
Impacted Files Coverage Δ
src/libServer/Server.h 0% <ø> (ø) ⬆️
src/libServer/Server.cpp 0.24% <0%> (+0.08%) ⬆️
src/libZilliqa/Zilliqa.cpp 4.23% <0%> (-0.9%) ⬇️
src/libLookup/Lookup.h 0% <0%> (ø) ⬆️
src/libNode/DSBlockProcessing.cpp 0% <0%> (ø) ⬆️
src/libDirectoryService/DSBlockPostProcessing.cpp 0% <0%> (ø) ⬆️
src/libNode/MicroBlockPostProcessing.cpp 0% <0%> (ø) ⬆️
src/libNode/FinalBlockProcessing.cpp 0% <0%> (ø) ⬆️
src/common/Constants.cpp 100% <0%> (ø) ⬆️
src/libDirectoryService/Coinbase.cpp 0% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4bb018...52d4ccb. Read the comment docs.

@ansnunez ansnunez added this to PRs in development in Core via automation Dec 15, 2018
@ansnunez ansnunez moved this from PRs in development to PRs needing review (please help!) in Core Dec 17, 2018
@kaikawaliu kaikawaliu changed the title Draft specs Updating specs for JSONRPC Dec 17, 2018
Core automation moved this from PRs needing review (please help!) to PRs approved - ready to merge! Dec 17, 2018
@ansnunez ansnunez merged commit 4cb3c64 into master Dec 17, 2018
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

5 participants