Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential deadlock when acquiring two locks #116

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Fix potential deadlock when acquiring two locks #116

merged 1 commit into from
Mar 13, 2018

Conversation

Gnnng
Copy link
Contributor

@Gnnng Gnnng commented Mar 13, 2018

No description provided.

@Gnnng Gnnng changed the title Fix potential deadlock when locking two mutexes Fix potential deadlock when acquiring two locks Mar 13, 2018
@Gnnng Gnnng requested a review from bb111189 March 13, 2018 03:43
@Gnnng
Copy link
Contributor Author

Gnnng commented Mar 13, 2018

See the equivalent code here: http://en.cppreference.com/w/cpp/thread/scoped_lock

@Gnnng Gnnng force-pushed the fix/compose-final-block-message branch from d146295 to 96bf974 Compare March 13, 2018 03:49
@Gnnng
Copy link
Contributor Author

Gnnng commented Mar 13, 2018

These bugs were introduced in #56. Should we review it once again?

@Gnnng Gnnng mentioned this pull request Mar 13, 2018
Open
@jiayaoqijia jiayaoqijia merged commit 609fe3e into master Mar 13, 2018
@jiayaoqijia jiayaoqijia deleted the fix/compose-final-block-message branch March 13, 2018 04:36
@bb111189 bb111189 mentioned this pull request Mar 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiayaoqijia jiayaoqijia jiayaoqijia approved these changes

@bb111189 bb111189 bb111189 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gnnng @jiayaoqijia @bb111189