Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some uninitialized params & Remove explicit copy constructor for std::move #1660

Merged
merged 3 commits into from May 27, 2019

Conversation

@kaikawaliu
Copy link
Contributor

commented May 13, 2019

Description

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test
@kaikawaliu kaikawaliu added the Ready label May 13, 2019
@kaikawaliu kaikawaliu requested review from bb111189 and ShengguangXiao May 13, 2019
@kaikawaliu kaikawaliu self-assigned this May 13, 2019
@kaikawaliu kaikawaliu added this to PRs in development in Core via automation May 13, 2019
@KaustubhShamshery

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

Can u use {} instead for uniform initialization syntax

@ansnunez ansnunez moved this from PRs in development to PRs needing review (please help!) in Core May 13, 2019
@codecov-io

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #1660 into master will decrease coverage by 1.1%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1660      +/-   ##
==========================================
- Coverage   33.75%   32.64%   -1.11%     
==========================================
  Files         270      270              
  Lines       32850    34951    +2101     
==========================================
+ Hits        11087    11411     +324     
- Misses      21763    23540    +1777
Impacted Files Coverage Δ
src/libData/AccountData/Transaction.h 95% <ø> (+1.66%) ⬆️
src/libData/AccountData/Transaction.cpp 88.88% <ø> (-1%) ⬇️
src/libData/AccountData/AccountStoreSC.h 100% <ø> (ø) ⬆️
src/libData/BlockData/Block/BlockBase.h 30% <ø> (-6.37%) ⬇️
src/libData/AccountData/AccountStore.cpp 60.81% <0%> (-0.85%) ⬇️
...rc/libDirectoryService/FinalBlockPreProcessing.cpp 0% <0%> (ø) ⬆️
...c/libDirectoryService/FinalBlockPostProcessing.cpp 0% <0%> (ø) ⬆️
src/libNode/FinalBlockProcessing.cpp 0% <0%> (ø) ⬆️
src/common/Constants.h 100% <0%> (ø) ⬆️
src/libPersistence/Retriever.cpp 0% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd64e2...25a7147. Read the comment docs.

@kaikawaliu kaikawaliu changed the title Fix some uninitialized params Fix some uninitialized params & Remove copy constructor for std::move May 13, 2019
@kaikawaliu kaikawaliu changed the title Fix some uninitialized params & Remove copy constructor for std::move Fix some uninitialized params & Remove explicit copy constructor for std::move May 13, 2019
Core automation moved this from PRs needing review (please help!) to PRs approved - ready to merge! May 24, 2019
@ansnunez ansnunez merged commit 4ed7a54 into master May 27, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) May 27, 2019
@Gnnng Gnnng deleted the fix/someiniter branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
  
PRs done (merged)
7 participants
You can’t perform that action at this time.