Sync/rejoin lagging-behind lookup nodes after recovery #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1726 +/- ##
========================================
- Coverage 33.5% 33.4% -0.1%
========================================
Files 270 270
Lines 33277 33383 +106
========================================
+ Hits 11148 11151 +3
- Misses 22129 22232 +103
Continue to review full report at Codecov.
|
ckyang
force-pushed
the
fix/recover_join
branch
8 times, most recently
from
160067a
to
078151e
Compare
ckyang
force-pushed
the
fix/recover_join
branch
10 times, most recently
from
c50a215
to
defde84
Compare
ckyang
changed the title
ckyang
changed the title
ckyang
changed the title
ckyang
force-pushed
the
fix/recover_join
branch
3 times, most recently
from
7024de6
to
d2d1e63
Compare
ckyang
force-pushed
the
fix/recover_join
branch
3 times, most recently
from
76db641
to
1279397
Compare
ckyang
force-pushed
the
fix/recover_join
branch
2 times, most recently
from
6579492
to
fdadad9
Compare
ckyang
force-pushed
the
fix/recover_join
branch
from
87a6f5c
to
8c744e1
Compare
sandipbhoir
reviewed
Aug 15, 2019
src/libLookup/Lookup.cpp
Outdated
| // retMicroBlocks.push_back(*mbptr); | ||
| // } | ||
| // } | ||
| LOG_GENERAL(INFO, "Reques for " << microBlockHashes.size() << " blocks"); |
src/libLookup/Lookup.cpp
Outdated
| // vector<TxnHash> txnhashes; | ||
| // txnhashes.clear(); | ||
| vector<TxnHash> txnhashes; | ||
| txnhashes.clear(); |
src/libLookup/Lookup.cpp
Outdated
|
|
||
| // bytes setTxnMsg = {MessageType::LOOKUP, | ||
| // LookupInstructionType::SETTXNFROMLOOKUP}; | ||
| vector<TransactionWithReceipt> txnvector; |
There was a problem hiding this comment.
can rename it to txns ??
sandipbhoir
approved these changes
Aug 15, 2019
ckyang
requested review from
ShengguangXiao
and removed request for
KaustubhShamshery
ShengguangXiao
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As https://github.com/Zilliqa/Issues/issues/542 mentioned, we need to synchronize after recovery, with the larger and larger size of persistence database.
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)