Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validateDB logging and add continueOnError option #1733

Merged
merged 1 commit into from Jul 23, 2019

Conversation

ansnunez
Copy link
Contributor

Description

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@ansnunez ansnunez added enhancement Ready Ready for review labels Jul 22, 2019
@ansnunez ansnunez self-assigned this Jul 22, 2019
@ansnunez ansnunez added this to PRs in development in Core via automation Jul 22, 2019
@codecov-io
Copy link

codecov-io commented Jul 22, 2019

Codecov Report

Merging #1733 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
- Coverage   33.55%   33.55%   -0.01%     
==========================================
  Files         270      270              
  Lines       33096    33103       +7     
==========================================
  Hits        11107    11107              
- Misses      21989    21996       +7
Impacted Files Coverage Δ
src/libNode/Node.h 0% <ø> (ø) ⬆️
src/libNode/Node.cpp 0.62% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd6f6a...df3b469. Read the comment docs.

@ansnunez ansnunez moved this from PRs in development to PRs needing review (please help!) in Core Jul 22, 2019
Core automation moved this from PRs needing review (please help!) to PRs approved - ready to merge! Jul 22, 2019
@ansnunez ansnunez merged commit 9679fc7 into master Jul 23, 2019
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jul 23, 2019
@n-hutton n-hutton deleted the valdbcontinue branch August 8, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ready Ready for review
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants