Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GetEpochFin in auto_back_up.py #1774

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Use GetEpochFin in auto_back_up.py #1774

merged 2 commits into from
Aug 16, 2019

Conversation

ckyang
Copy link
Contributor

@ckyang ckyang commented Aug 15, 2019

Description

In order to avoid the possible crash when calling auto_back_up.py without Zilliqa process running, change GetCurrentMiniEpoch to GetEpochFin.

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@ckyang ckyang self-assigned this Aug 15, 2019
@ckyang ckyang added the Ready Ready for review label Aug 15, 2019
@ckyang ckyang added this to PRs in development in Core via automation Aug 15, 2019
@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

Merging #1774 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1774      +/-   ##
=========================================
+ Coverage    33.5%   33.5%   +<.01%     
=========================================
  Files         270     270              
  Lines       33277   33277              
=========================================
+ Hits        11148   11151       +3     
+ Misses      22129   22126       -3
Impacted Files Coverage Δ
src/libUtils/SWInfo.cpp 93.12% <0%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8881cbe...76d65bf. Read the comment docs.

@ansnunez ansnunez moved this from PRs in development to PRs needing review in Core Aug 16, 2019
Core automation moved this from PRs needing review to PRs approved - ready to merge! Aug 16, 2019
@ansnunez ansnunez merged commit 0dc4f74 into master Aug 16, 2019
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Aug 16, 2019
@n-hutton n-hutton deleted the fix/autobackepochfin branch August 8, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

5 participants