Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control txns backup to S3 #1780

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Control txns backup to S3 #1780

merged 1 commit into from
Aug 23, 2019

Conversation

sandipbhoir
Copy link
Contributor

Description

Addresses - https://github.com/Zilliqa/Issues/issues/570

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@sandipbhoir sandipbhoir added the Ready Ready for review label Aug 22, 2019
@sandipbhoir sandipbhoir self-assigned this Aug 22, 2019
@sandipbhoir sandipbhoir added this to PRs in development in Core via automation Aug 22, 2019
@codecov-io
Copy link

Codecov Report

Merging #1780 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1780      +/-   ##
==========================================
+ Coverage   33.36%   33.36%   +<.01%     
==========================================
  Files         270      270              
  Lines       33417    33420       +3     
==========================================
+ Hits        11148    11150       +2     
- Misses      22269    22270       +1
Impacted Files Coverage Δ
src/common/Constants.h 100% <ø> (ø) ⬆️
src/libNode/MicroBlockPreProcessing.cpp 0% <0%> (ø) ⬆️
src/common/Constants.cpp 99.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e8aa6...b16f73a. Read the comment docs.

@ansnunez ansnunez moved this from PRs in development to PRs needing review in Core Aug 23, 2019
Core automation moved this from PRs needing review to PRs approved - ready to merge! Aug 23, 2019
@ansnunez ansnunez merged commit 8890544 into master Aug 23, 2019
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Aug 23, 2019
@n-hutton n-hutton deleted the feature/disabletnxsbackup branch August 8, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants