Force serialization of primitive proto fields for block and tx data

[ansnunez]

Description

Proto3 does not serialize fields that are set to default value (reference)

This is a breaking change from proto2, and will be problematic for any of our code that relies on byte consistency (e.g., hashes based on serialized blocks).

To fix this, we force the serialization of these fields by wrapping each one in a oneof. (reference)

Backward Compatibility

• This is not a breaking change
• This is a breaking change

Review Suggestion

Status

Implementation

• ready for review

Integration Test (Core Team)

• local machine test

• small-scale cloud test

[codecov-io]

Codecov Report

Merging #1793 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1793      +/-   ##
==========================================
+ Coverage   33.77%   33.83%   +0.06%     
==========================================
  Files         274      274              
  Lines       33732    33994     +262     
==========================================
+ Hits        11394    11503     +109     
- Misses      22338    22491     +153

Impacted Files	Coverage Δ
src/libUtils/SWInfo.cpp	90.83% <0%> (-2.3%)	⬇️
src/libPersistence/BlockStorage.cpp	31.26% <0%> (+3.61%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fbb94e...aa7f51c. Read the comment docs.