Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the correctness of hash inside the block #1794

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Conversation

KaustubhShamshery
Copy link
Contributor

@KaustubhShamshery KaustubhShamshery commented Sep 4, 2019

Description

Increase checks inside the validator.

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@KaustubhShamshery KaustubhShamshery self-assigned this Sep 4, 2019
@KaustubhShamshery KaustubhShamshery added the Ready Ready for review label Sep 4, 2019
@KaustubhShamshery KaustubhShamshery added this to PRs in development in Core via automation Sep 4, 2019
Core automation moved this from PRs in development to PRs approved - ready to merge! Sep 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #1794 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1794      +/-   ##
==========================================
- Coverage   33.76%   33.75%   -0.02%     
==========================================
  Files         274      274              
  Lines       33737    33750      +13     
==========================================
  Hits        11391    11391              
- Misses      22346    22359      +13
Impacted Files Coverage Δ
src/libValidator/Validator.cpp 2.81% <0%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 670ec13...d354823. Read the comment docs.

@ansnunez ansnunez merged commit d5cf552 into master Sep 5, 2019
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Sep 5, 2019
@n-hutton n-hutton deleted the feature/check_hash branch August 8, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants