Fix genesis DS block hash not correct problem

[ShengguangXiao]

Description

Fix genesis DS block hash not correct problem, and also add auto test case to verify in the future in the change break block hash calculation.

Backward Compatibility

• This is not a breaking change
• This is a breaking change

Review Suggestion

Status

Implementation

• ready for review

Integration Test (Core Team)

• local machine test

• small-scale cloud test

[codecov-io]

Codecov Report

Merging #1798 into master will increase coverage by 0.23%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1798      +/-   ##
==========================================
+ Coverage   33.75%   33.98%   +0.23%     
==========================================
  Files         274      274              
  Lines       33750    33757       +7     
==========================================
+ Hits        11391    11473      +82     
+ Misses      22359    22284      -75

Impacted Files	Coverage Δ
src/common/Constants.h	100% <ø> (ø)	⬆️
src/libLookup/Synchronizer.cpp	15.11% <100%> (+15.11%)	⬆️
tests/Message/Test_Messenger_Compatibility.cpp	100% <100%> (ø)	⬆️
src/depends/common/FixedHash.h	84% <0%> (+2%)	⬆️
src/libUtils/DataConversion.h	84.37% <0%> (+12.5%)	⬆️
src/libData/BlockData/BlockHeader/BlockHashSet.h	55.26% <0%> (+18.42%)	⬆️
src/depends/common/CommonData.cpp	21.91% <0%> (+21.91%)	⬆️
src/libUtils/SWInfo.h	69.56% <0%> (+56.52%)	⬆️
src/libData/BlockData/BlockHeader/DSBlockHeader.h	88.88% <0%> (+83.33%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cf552...e122bb5. Read the comment docs.

[PirateGypsy]

Unsiscribe Ryan Hicks c. 501.553.1003 | 24/hr ER. 844.333.0939 E3Response.com

…

On Sep 4, 2019, at 21:49, Xiao Shengguang ***@***.***> wrote: Description Fix genesis DS block hash not correct problem, and also add auto test case to verify in the future in the change break block hash calculation. Backward Compatibility This is not a breaking change This is a breaking change Review Suggestion Status Implementation ready for review Integration Test (Core Team) local machine test small-scale cloud test You can view, comment on, or merge this pull request online at: #1798 Commit Summary Fix genesis DS block hash not correct problem File Changes M src/common/Constants.h (2) M src/libLookup/Synchronizer.cpp (13) M src/libLookup/Synchronizer.h (2) M tests/Message/CMakeLists.txt (2) M tests/Message/Test_Messenger_Compatibility.cpp (16) Patch Links: https://github.com/Zilliqa/Zilliqa/pull/1798.patch https://github.com/Zilliqa/Zilliqa/pull/1798.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.