Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return code & data if they are present #1804

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Conversation

KaustubhShamshery
Copy link
Contributor

@KaustubhShamshery KaustubhShamshery commented Sep 5, 2019

Description

GetTransaction API to return code and data of the transaction if present.

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@KaustubhShamshery KaustubhShamshery added the Ready Ready for review label Sep 5, 2019
@KaustubhShamshery KaustubhShamshery added this to PRs in development in Core via automation Sep 5, 2019
@KaustubhShamshery KaustubhShamshery added on hold Untested Haven't been tested yet and removed Ready Ready for review labels Sep 5, 2019
@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #1804 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1804      +/-   ##
==========================================
+ Coverage   31.97%   31.97%   +<.01%     
==========================================
  Files         278      278              
  Lines       34841    34847       +6     
==========================================
+ Hits        11141    11144       +3     
- Misses      23700    23703       +3
Impacted Files Coverage Δ
src/libServer/JSONConversion.cpp 0% <0%> (ø) ⬆️
src/libUtils/SWInfo.cpp 93.12% <0%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba609c...49250bd. Read the comment docs.

@ansnunez ansnunez removed the on hold label Sep 6, 2019
@ansnunez ansnunez moved this from PRs in development to PRs needing review in Core Sep 6, 2019
Core automation moved this from PRs needing review to PRs approved - ready to merge! Sep 6, 2019
@ansnunez ansnunez merged commit 6e8621e into master Sep 6, 2019
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Sep 6, 2019
@n-hutton n-hutton deleted the feature/display_code_data branch August 8, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Untested Haven't been tested yet
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants