Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-5.0] Fixes for Smart Contract execution on empty map key & RevertCommitTemp #1818

Merged
merged 1 commit into from Sep 6, 2019
Merged

[release-5.0] Fixes for Smart Contract execution on empty map key & RevertCommitTemp #1818

merged 1 commit into from Sep 6, 2019

Conversation

ansnunez
Copy link
Contributor

@ansnunez ansnunez commented Sep 6, 2019 •
edited

#1815

Description

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@ansnunez ansnunez added the Ready Ready for review label Sep 6, 2019
@ansnunez ansnunez self-assigned this Sep 6, 2019
@ansnunez ansnunez added this to PRs in development in Core via automation Sep 6, 2019
@ansnunez ansnunez moved this from PRs in development to PRs needing review in Core Sep 6, 2019
Core automation moved this from PRs needing review to PRs approved - ready to merge! Sep 6, 2019
@ansnunez ansnunez merged commit 6a0b944 into release-5.0 Sep 6, 2019
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Sep 6, 2019
@ansnunez ansnunez deleted the fix/emptymapkey-rel5.0 branch September 6, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaivaswatha vaivaswatha vaivaswatha approved these changes

@kaikawaliu kaikawaliu kaikawaliu approved these changes

@ShengguangXiao ShengguangXiao Awaiting requested review from ShengguangXiao

Assignees

@ansnunez ansnunez

Labels
Ready Ready for review
Projects
Core
  
PRs done (merged)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ansnunez @vaivaswatha @kaikawaliu