Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data_migrate from build #1874

Merged
merged 1 commit into from Sep 17, 2019
Merged

Remove data_migrate from build #1874

merged 1 commit into from Sep 17, 2019

Conversation

ansnunez
Copy link
Contributor

Description

data_migrate was only needed during v5.0.0 network upgrade. Moving forward, we can exclude it from the build (eventually we can consider removing from src as well).

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@ansnunez ansnunez added the Ready Ready for review label Sep 17, 2019
@ansnunez ansnunez self-assigned this Sep 17, 2019
@ansnunez ansnunez added this to PRs in development in Core via automation Sep 17, 2019
Core automation moved this from PRs in development to PRs approved - ready to merge! Sep 17, 2019
@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #1874 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1874   +/-   ##
=======================================
  Coverage   32.19%   32.19%           
=======================================
  Files         279      279           
  Lines       35077    35077           
=======================================
  Hits        11294    11294           
  Misses      23783    23783

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51777c5...7841a61. Read the comment docs.

@ansnunez ansnunez merged commit 32def4f into master Sep 17, 2019
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Sep 17, 2019
@ansnunez ansnunez deleted the remove_data_migrate branch September 17, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants