Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed image references in State Diagrams.md #2

Merged
merged 0 commits into from Dec 31, 2017

Conversation

Sajjon
Copy link
Contributor

@Sajjon Sajjon commented Dec 31, 2017

The image references pointed to another repository. I also changed them to be relative, instead of absolute.

@bb111189 bb111189 self-requested a review December 31, 2017 17:41
Copy link
Contributor

@bb111189 bb111189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks for the fix.

@bb111189 bb111189 merged this pull request into Zilliqa:master Dec 31, 2017
bb111189 pushed a commit that referenced this pull request Jan 2, 2018
Fixed image references in State Diagrams.md
sidutta pushed a commit that referenced this pull request Jan 3, 2018
Fixed image references in State Diagrams.md
@ckyang ckyang mentioned this pull request Jun 4, 2018
art-gor added a commit that referenced this pull request Jul 26, 2022
art-gor added a commit that referenced this pull request Aug 2, 2022
art-gor added a commit that referenced this pull request Aug 12, 2022
art-gor added a commit that referenced this pull request Aug 19, 2022
art-gor added a commit that referenced this pull request Sep 6, 2022
Steve-White-UK added a commit that referenced this pull request Aug 17, 2023
* Add TODOs to fix

* p2pcomm refactor pt.1

* update #2, sending part, relaxed blacklisting policy

* update #3, some wiring

* fixing one stupid thing

* more fixes

* redundant log message eliminated

* dont assigh empty pubkeys

* fix #1

* hotfix about l2 comm

* extra logging

* fix cv_setRejoinRecovery

* fix cv_dsInfoUpdate

* fix cv_shardStruct

* fix cv_vcDsBlockProcessed

* fix cv_vcFinalBlockProcessed

* fix cv_dsLeaderTxnPool

* fix cv_setStateDeltasFromSeed

* fix cv_setCosigRewardsFromSeed

* p2p distributed test tool

* build fix

* extra logging

* Fix Dockerfile to add neccassary apt-get update

* outgoing connections to multiplier nodes follow the old protocol (w/reconnects)

* attempt to fix GetDSLeaderTxPool

* libevent gone

* some TODOs explained

* Just a checkpoint locally

* Fixing test

* Made modifications to logger to make LOG_MARKER very quiet
Changed flag in lookup.cpp to send everything to dsgaurd
Replaced isolated-server-accounts.json with single entry for use with the scripts :
   FundFromPrimaryAccount.ts in the hardhat EvmAcceptanceTests script dir
Updated constants.xml
   open telemetry settings for localdev.py
   reduced extra time for consensus as described in Zelensky doc.

Did basic startup tests

Note this is derived from master

updated localdev.py to start the appropriate number of nodes

localdev.py now defaults to using isolated-server-accounts

# it is sufficient to use this to bring up the system once you have edited your hosts to reflect ip address from minikube ip

./scripts/localdev.py up

* Made modifications to logger to make LOG_MARKER very quiet
Changed flag in lookup.cpp to send everything to dsgaurd
Replaced isolated-server-accounts.json with single entry for use with the scripts :
   FundFromPrimaryAccount.ts in the hardhat EvmAcceptanceTests script dir
Updated constants.xml
   open telemetry settings for localdev.py
   reduced extra time for consensus as described in Zelensky doc.

Did basic startup tests

Note this is derived from master

updated localdev.py to start the appropriate number of nodes

localdev.py now defaults to using isolated-server-accounts

# it is sufficient to use this to bring up the system once you have edited your hosts to reflect ip address from minikube ip

./scripts/localdev.py up

* Increasing POW window

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Fixing errorneous test

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Reverted newer tests

* Reverted newer tests
Turned off special handling for multiplier, will remove code on next pass.

* Reverted newer tests
Turned off special handling for multiplier, will remove code on next pass.

* Some in-progress work

* Change genesis account

* Reverted newer tests
Turned off special handling for multiplier, will remove code on next pass.

---------

Co-authored-by: Valeriy Zamaraiev <valeriy@zilliqa.com>
Co-authored-by: Artem <artgor4github@gmail.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
yaron-zilliqa pushed a commit that referenced this pull request Aug 23, 2023
* Add TODOs to fix

* p2pcomm refactor pt.1

* update #2, sending part, relaxed blacklisting policy

* update #3, some wiring

* fixing one stupid thing

* more fixes

* redundant log message eliminated

* dont assigh empty pubkeys

* fix #1

* hotfix about l2 comm

* extra logging

* fix cv_setRejoinRecovery

* fix cv_dsInfoUpdate

* fix cv_shardStruct

* fix cv_vcDsBlockProcessed

* fix cv_vcFinalBlockProcessed

* fix cv_dsLeaderTxnPool

* fix cv_setStateDeltasFromSeed

* fix cv_setCosigRewardsFromSeed

* p2p distributed test tool

* build fix

* extra logging

* Fix Dockerfile to add neccassary apt-get update

* outgoing connections to multiplier nodes follow the old protocol (w/reconnects)

* attempt to fix GetDSLeaderTxPool

* libevent gone

* some TODOs explained

* Just a checkpoint locally

* Fixing test

* Made modifications to logger to make LOG_MARKER very quiet
Changed flag in lookup.cpp to send everything to dsgaurd
Replaced isolated-server-accounts.json with single entry for use with the scripts :
   FundFromPrimaryAccount.ts in the hardhat EvmAcceptanceTests script dir
Updated constants.xml
   open telemetry settings for localdev.py
   reduced extra time for consensus as described in Zelensky doc.

Did basic startup tests

Note this is derived from master

updated localdev.py to start the appropriate number of nodes

localdev.py now defaults to using isolated-server-accounts

./scripts/localdev.py up

* Made modifications to logger to make LOG_MARKER very quiet
Changed flag in lookup.cpp to send everything to dsgaurd
Replaced isolated-server-accounts.json with single entry for use with the scripts :
   FundFromPrimaryAccount.ts in the hardhat EvmAcceptanceTests script dir
Updated constants.xml
   open telemetry settings for localdev.py
   reduced extra time for consensus as described in Zelensky doc.

Did basic startup tests

Note this is derived from master

updated localdev.py to start the appropriate number of nodes

localdev.py now defaults to using isolated-server-accounts

./scripts/localdev.py up

* Increasing POW window

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Fixing errorneous test

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Reverted newer tests

* Reverted newer tests
Turned off special handling for multiplier, will remove code on next pass.

* Reverted newer tests
Turned off special handling for multiplier, will remove code on next pass.

* Some in-progress work

* Change genesis account

* Reverted newer tests
Turned off special handling for multiplier, will remove code on next pass.

---------

Co-authored-by: Valeriy Zamaraiev <valeriy@zilliqa.com>
Co-authored-by: Artem <artgor4github@gmail.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants