Improve multicast in non-ideal cases with connectivity with some of peers #2161
Conversation
src/libNetwork/P2PComm.cpp
Outdated
| m_startbyte, m_hash)); | ||
|
|
||
| // Park the thread if message sending taking more than expected | ||
| auto status = hThread->wait_for(std::chrono::seconds(5)); |
There was a problem hiding this comment.
If I recall correctly, messages that go beyond a few MB can potentially take (maybe) more than 5 seconds. Maybe we can add this duration to constants.xml instead so we can adjust easily if necessary.
src/libNetwork/P2PComm.cpp
Outdated
| auto status = hThread->wait_for(std::chrono::seconds(5)); | ||
|
|
||
| if (status == std::future_status::timeout) { | ||
| LOG_GENERAL(WARNING, "Sending message to " |
There was a problem hiding this comment.
In the interest of brevity, I suggest to shorten to: "Sending delayed for "
Anyway the presence of the LOG_MARKER will already help us find the scope for this entire execution in the logs.
There was a problem hiding this comment.
sure. but i still prefer the message logging for peer, ofcourse short one like you suggested.
Codecov Report
@@ Coverage Diff @@
## master #2161 +/- ##
==========================================
- Coverage 28.50% 28.50% -0.01%
==========================================
Files 275 275
Lines 37288 37296 +8
==========================================
+ Hits 10629 10631 +2
- Misses 26659 26665 +6
Continue to review full report at Codecov.
|
Description
https://github.com/Zilliqa/Issues/issues/647
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)