[master] Remote State Reads #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjcnn
reviewed
Feb 20, 2021
|
I've looked through the changes, and apart from the version issue it passes the smell test. I don't know enough about the blockchain layer to do a proper review, though. |
|
Ping !. I have some more changes pending that I need to do on top of this change after its merged. So it would be nice to have this merged at the earliest. |
sandipbhoir
suggested changes
Feb 24, 2021
| @@ -579,6 +580,7 @@ bool AccountStoreSC<MAP>::UpdateAccounts(const uint64_t& blockNum, | |||
|
|
|||
| if (ret && !ParseCallContract(gasRemained, runnerPrint, receipt, | |||
| tree_depth, scilla_version)) { | |||
| Contract::ContractStorage2::GetContractStorage().RevertPrevState(); | |||
There was a problem hiding this comment.
may not need this since it called later at line 588.
| @@ -98,6 +98,7 @@ bool SerializeToArray(const T& protoMessage, bytes& dst, | |||
| string ContractStorage2::GenerateStorageKey(const dev::h160& addr, | |||
| const string& vname, | |||
| const vector<string>& indices) { | |||
| LOG_MARKER(); | |||
ansnunez
suggested changes
Feb 24, 2021
ansnunez
suggested changes
Feb 24, 2021
| @@ -579,6 +580,7 @@ bool AccountStoreSC<MAP>::UpdateAccounts(const uint64_t& blockNum, | |||
|
|
|||
| if (ret && !ParseCallContract(gasRemained, runnerPrint, receipt, | |||
| tree_depth, scilla_version)) { | |||
| Contract::ContractStorage2::GetContractStorage().RevertPrevState(); | |||
ansnunez
suggested changes
Feb 24, 2021
sandipbhoir
approved these changes
Feb 25, 2021
ansnunez
approved these changes
Feb 25, 2021
ansnunez
force-pushed
the
feature/remote_state_reads
branch
from
b30f0e4
to
ede0c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a redo of #2167 without the MPT / Trie parts.
Backward Compatibility
Review Suggestion
Status
It is ready for review, but requires more testing. I might need @kaikawaliu's and @renlulu's help for that.
Implementation
Integration Test (Core Team)