Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Enable Scilla Server for Isolated Server #2457

Merged
merged 1 commit into from
Feb 24, 2021
Merged

[master] Enable Scilla Server for Isolated Server #2457

merged 1 commit into from
Feb 24, 2021

Conversation

ansnunez
Copy link
Contributor

Description

Same as #2456

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@ansnunez ansnunez self-assigned this Feb 23, 2021
@github-actions github-actions bot changed the title Enable Scilla Server for Isolated Server [master] Enable Scilla Server for Isolated Server Feb 23, 2021
@github-actions github-actions bot added this to PRs in development in Core Feb 23, 2021
Annihilatopia
Annihilatopia approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@Annihilatopia Annihilatopia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Core automation moved this from PRs in development to PRs approved - ready to merge! Feb 24, 2021
@ansnunez ansnunez merged commit 3cb97ee into master Feb 24, 2021
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Feb 24, 2021
@ansnunez ansnunez deleted the isoServer/master branch February 24, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Annihilatopia Annihilatopia Annihilatopia approved these changes

@sunny-teo9000 sunny-teo9000 sunny-teo9000 approved these changes

@KaustubhShamshery KaustubhShamshery Awaiting requested review from KaustubhShamshery

Assignees

@ansnunez ansnunez

Labels
None yet
Projects
Core
  
PRs done (merged)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ansnunez @Annihilatopia @sunny-teo9000