[master] Add bech32 utilities and initial migration to bech32 address #2459
Conversation
github-actions
bot
changed the title
src/libUtils/Bech32.cpp
Outdated
| bool Bech32::HasZilHrp(const std::string& input) { | ||
| if (input.length() < 4) return false; | ||
|
|
||
| auto hrp = boost::string_view(input); |
src/libUtils/Bech32.cpp
Outdated
| return ""; | ||
| } | ||
|
|
||
| for (size_t i = 0; i < inputSize; ++i) { |
src/libUtils/Bech32.cpp
Outdated
| } | ||
|
|
||
| for (size_t i = 0; i < inputSize; ++i) { | ||
| char c = input[i]; |
There was a problem hiding this comment.
can use const auto& here too
src/libUtils/Bech32.cpp
Outdated
|
|
||
| #include "Bech32.h" | ||
| #include "libServer/AddressChecksum.h" | ||
|
|
There was a problem hiding this comment.
can use using namespace std in .cpp file
sunny-teo9000
force-pushed
the
feature/migrationtobech32
branch
from
6a56e0d
to
7d0e84d
Compare
|
https://github.com/Zilliqa/cryptoutils/tree/main/lib Can we use bech32 from cryptoutils? This is to avoid 2 copy of bech32. @vaivaswatha has recently created it and will be using for his VM. I think on the core side, ethash is already using cryptoutils |
Example usage: https://github.com/Zilliqa/scilla-vm/blob/4c58dae89aa3bc1567f21ad1ad9aa952ee089142/libsrtl/ScillaBuiltins.cpp#L608. This function and the next one do decoding and encoding respectively. |
sunny-teo9000
force-pushed
the
feature/migrationtobech32
branch
from
7d0e84d
to
bb1dca6
Compare
sunny-teo9000
force-pushed
the
feature/migrationtobech32
branch
from
bb1dca6
to
13065fe
Compare
src/libServer/LookupServer.cpp
Outdated
| const unsigned int PAGE_SIZE = 10; | ||
| const unsigned int NUM_PAGES_CACHE = 2; | ||
| const unsigned int TXN_PAGE_SIZE = 100; | ||
| const unsigned int UINT8_ADDR_SIZE = ACC_ADDR_SIZE * 2; |
There was a problem hiding this comment.
should be HEX_ADDR_SIZE
|
Can we have the unit test again? |
sunny-teo9000
force-pushed
the
feature/migrationtobech32
branch
2 times, most recently
from
3bb0588
to
b5d52c7
Compare
GetBalance GetSmartContractCode GetSmartContractInit GetSmartContracts GetSmartContractState GetSmartContractSubState
sunny-teo9000
force-pushed
the
feature/migrationtobech32
branch
from
b5d52c7
to
f879e52
Compare
Description
To add Bech32 utilities and allow the following API to accept both base16 and bech32 for now.
GetBalance
GetSmartContractCode
GetSmartContractInit
GetSmartContracts
GetSmartContractState
GetSmartContractSubState
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)
Was tested with a local isolated server, testing with the bech32 and base16 address