[master] Change INCRDB_DSNUMS_WITH_STATEDELTAS default value from 10 to 5 #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
KaustubhShamshery
approved these changes
Feb 25, 2021
sandipbhoir
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
State deltas have grown significantly in size (sometimes each Tx can have 100kB+).
This puts a strain on seeds who must transmit the data.
It also means data syncing (especially during rolling upgrade of pods) can take a very long time.
This PR only changes the constants file, but it will help us remember to introduce the change in the next scheduled upgrade.
Testing will be done during upgrade rehearsal.
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)