[master] Updates to external state fetch in ContractStorage2 #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
vaivaswatha
force-pushed
the
fix/remote_state_reads
branch
from
15d6ee9
to
f48255e
Compare
ansnunez
suggested changes
Feb 26, 2021
ansnunez
approved these changes
Mar 1, 2021
ansnunez
suggested changes
Mar 3, 2021
ansnunez
approved these changes
Mar 3, 2021
vaivaswatha
force-pushed
the
fix/remote_state_reads
branch
from
9ffab8e
to
b80195d
Compare
sandipbhoir
approved these changes
Mar 4, 2021
ansnunez
force-pushed
the
fix/remote_state_reads
branch
from
b80195d
to
74bf8f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
query.mapdepthmay be set to -1 by Scilla (in case of external states, Scilla cannot know this value). The blockchain needs to fetch the value from its database and use it for the lookup.query.ignorevalmay be set for nonmap fields too. In such a case, the blockchain only needs to return the type of the field and not the value.foundValneeds to be set tofalseand that's it. This will enable Scilla to check for presence of a field in a contract without it becoming an error.Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)