Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Lookup to dispatch txn packet to shard leader as well #2468

Merged
merged 1 commit into from
Mar 10, 2021
Merged

[master] Lookup to dispatch txn packet to shard leader as well #2468

merged 1 commit into from
Mar 10, 2021

Conversation

sandipbhoir
Copy link
Contributor

@sandipbhoir sandipbhoir commented Mar 9, 2021 •
edited

Description

This PR basically does folllowing:

  • Include shardleader in NUM_NODES_TO_SEND_LOOKUP while dispatching txnpkt.
    Previously, leader is excluded.
  • Shard leader is first in the queue to be sent.
  • Redundant usage of constant UPGRADE_TARGET_DS_NUM is removed.

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@sandipbhoir sandipbhoir self-assigned this Mar 9, 2021
@github-actions github-actions bot changed the title Lookup to dispatch txn packet to shard leader as well [master] Lookup to dispatch txn packet to shard leader as well Mar 9, 2021
@github-actions github-actions bot added this to PRs in development in Core Mar 9, 2021
@sandipbhoir sandipbhoir added Ready Ready for review and removed Testing_InProgress labels Mar 9, 2021
Core automation moved this from PRs in development to PRs approved - ready to merge! Mar 10, 2021
@ansnunez ansnunez merged commit 6f0177e into master Mar 10, 2021
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Mar 10, 2021
@ansnunez ansnunez deleted the fix/includeldr branch March 10, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaustubhShamshery KaustubhShamshery KaustubhShamshery approved these changes

@ansnunez ansnunez ansnunez approved these changes

Assignees

@sandipbhoir sandipbhoir

Labels
Ready Ready for review
Projects
Core
  
PRs done (merged)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sandipbhoir @KaustubhShamshery @ansnunez