[master] Exclude shard guards from PoW reputation #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
ansnunez
suggested changes
Mar 11, 2021
sunny-teo9000
force-pushed
the
fix/ExcludeShardGuardFromRep
branch
from
c1adcdb
to
c063579
Compare
sandipbhoir
suggested changes
Mar 11, 2021
| // Iterate PoWs based on key ordering in the map | ||
| for (const auto& kv : m_allPoWs) { | ||
| const auto& pubKey = kv.first; | ||
| uint8_t priority = 0; | ||
| auto reputation = m_mapNodeReputation.find(pubKey); |
There was a problem hiding this comment.
better if can move this line to line 592?
| continue; | ||
| } | ||
| priority = maxPriority; | ||
| LOG_GENERAL(INFO, "Node=" << pubKey << "Reputation=(shard guard)"); | ||
| listNodePriority.emplace_back(pubKey, priority); |
There was a problem hiding this comment.
may be just use max_priority when adding back.
ansnunez
suggested changes
Mar 11, 2021
| continue; | ||
| } | ||
| priority = maxPriority; | ||
| LOG_GENERAL(INFO, "Node=" << pubKey << "Reputation=(shard guard)"); |
There was a problem hiding this comment.
Suggested change
| LOG_GENERAL(INFO, "Node=" << pubKey << "Reputation=(shard guard)"); | |
| LOG_GENERAL(INFO, "Node=" << pubKey << " Reputation=(shard guard)"); |
sunny-teo9000
force-pushed
the
fix/ExcludeShardGuardFromRep
branch
from
c063579
to
55544ae
Compare
ansnunez
approved these changes
Mar 11, 2021
sunny-teo9000
force-pushed
the
fix/ExcludeShardGuardFromRep
branch
from
55544ae
to
4a0dc2c
Compare
sandipbhoir
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prevent shard guards from being affected by the reputation, priority is being set to the highest for SHARD_GUARD_TOL percent of nodes.
This will be further trimmed in the SortPoWSoln to fit the shard structure.
There will only be a maximum of SHARD_GUARD_TOL percent of shard guards in the shards.
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)