Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Add another max peer connection constant for p2pseed only #2471

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

chetan-zilliqa
Copy link
Contributor

Description

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

A new constant, MAX_PEER_CONNECTION_P2PSEED = 20 is added in constants.xml.This tracks the simultaneous max connection for key whitelisted p2pseed.

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@chetan-zilliqa chetan-zilliqa self-assigned this Mar 16, 2021
@github-actions github-actions bot changed the title Zil 2526 p2pseed [master] Zil 2526 p2pseed Mar 16, 2021
@github-actions github-actions bot added this to PRs in development in Core Mar 16, 2021
@chetan-zilliqa chetan-zilliqa added Ready Ready for review and removed Testing_InProgress labels Mar 17, 2021
@chetan-zilliqa chetan-zilliqa requested review from ansnunez and sandipbhoir and removed request for ansnunez March 17, 2021 08:31
@sandipbhoir sandipbhoir changed the title [master] Zil 2526 p2pseed [master] Add another max peer connection constant for p2pseed only Mar 17, 2021
Core automation moved this from PRs in development to PRs approved - ready to merge! Mar 17, 2021
@ansnunez ansnunez merged commit 804f8a2 into master Mar 18, 2021
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Mar 18, 2021
@ansnunez ansnunez deleted the zil-2526-p2pseed branch March 18, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants