[master] Add new version of GetPendingTxns API using RemoteStorageDB #2482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR re-introduces
GetPendingTxns
API, but now we fetch pending txns (i.e.,modificationStatus
< 2) from remote storage DB instead of using the local pending transaction pool.The query is:
{ "epochUpdated" : { "$gt" : "<curr epoch - PENDING_TXN_QUERY_NUM_EPOCHS>" }, "epochUpdated" : { "$lte" : "<curr epoch>" }, "modificationState" : { "$lt" : 2 } }
Only the first
PENDING_TXN_QUERY_MAX_RESULTS
results are fetched. Results are sorted byepochUpdated
descending. OnlyID
andstatus
fields are fetched.In a way this will be a breaking change as the original
GetPendingTxns
had no results limit, and also included dropped/rejected transactions.Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)