Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Add new version of GetPendingTxns API using RemoteStorageDB #2482

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

ansnunez
Copy link
Contributor

@ansnunez ansnunez commented Mar 23, 2021

Description

This PR re-introduces GetPendingTxns API, but now we fetch pending txns (i.e., modificationStatus < 2) from remote storage DB instead of using the local pending transaction pool.

The query is:
{ "epochUpdated" : { "$gt" : "<curr epoch - PENDING_TXN_QUERY_NUM_EPOCHS>" }, "epochUpdated" : { "$lte" : "<curr epoch>" }, "modificationState" : { "$lt" : 2 } }

Only the first PENDING_TXN_QUERY_MAX_RESULTS results are fetched. Results are sorted by epochUpdated descending. Only ID and status fields are fetched.

In a way this will be a breaking change as the original GetPendingTxns had no results limit, and also included dropped/rejected transactions.

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@ansnunez ansnunez self-assigned this Mar 23, 2021
@github-actions github-actions bot changed the title Add new version of GetPendingTxns API using RemoteStorageDB [master] Add new version of GetPendingTxns API using RemoteStorageDB Mar 23, 2021
@github-actions github-actions bot added this to PRs in development in Core Mar 23, 2021
@ansnunez ansnunez added Ready Ready for review and removed Testing_InProgress labels Mar 25, 2021
@ansnunez ansnunez moved this from PRs in development to PRs needing review in Core Mar 25, 2021
Core automation moved this from PRs needing review to PRs approved - ready to merge! Mar 29, 2021
@sandipbhoir sandipbhoir merged commit 975db33 into master Mar 29, 2021
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Mar 29, 2021
@sandipbhoir sandipbhoir deleted the getpendingtxn-remotestoragedb branch March 29, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants