[master] Add generated test txns to remote storage DB #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
chetan-zilliqa
requested changes
Mar 25, 2021
chetan-zilliqa
approved these changes
Mar 25, 2021
sandipbhoir
approved these changes
Mar 25, 2021
ansnunez
force-pushed
the
remotedb-gentxn
branch
from
e39d75e
to
1f07eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lookup::GenTxnToSendis used by developer testnets to generate test transactions.Currently these test transactions are not inserted into the remote db.
Notes:
SendTxnPacketToNodes,SendTxnPacketPrepareis called twice (SendTxnPacketPreparein turn callsGenTxnToSend), so we need to avoid duplicate insertion into the remote db during the second call.USE_REMOTE_TXN_CREATORfromGenTxnToSendtoSendTxnPacketPrepareso that we no longer see pointless "GenTxnToSend failed" messages in mainnet.Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)