[master] Fix corner case : handle receving of stale txblocks #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
ansnunez
approved these changes
Apr 1, 2021
bb111189
approved these changes
Apr 1, 2021
ansnunez
approved these changes
Apr 1, 2021
chetan-zilliqa
approved these changes
Apr 1, 2021
comment handle dsepoch cross at startup of seed
sandipbhoir
force-pushed
the
fix/settxblock
branch
from
660c560
to
1ec21e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles the corner case where it is lagging in previous epoch before starting
RejoinAs*** -> StartSyncronization.Before fix: Node receives txblock from latest ds epoch however misses the tailend txepoch from previous ds epoch. This is because upperseeds only sends txblocks from latest dsepoch.
After fix: It identifies the broken txblock chain and rejoin instead.
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)